linux-kernel - Re: [PATCH] af_packet: Don't use skb after dev_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <4B4E3834.3000609@majjas.com>
Date:	Wed, 13 Jan 2010 16:16:36 -0500
From:	Michael Breuer <mbreuer@...jas.com>
To:	Jarek Poplawski <jarkao2@...il.com>
Cc:	Stephen Hemminger <shemminger@...ux-foundation.org>,
	David Miller <davem@...emloft.net>, akpm@...ux-foundation.org,
	flyboy@...il.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()

On 1/13/2010 4:09 PM, Jarek Poplawski wrote:
> On Wed, Jan 13, 2010 at 03:39:37PM -0500, Michael Breuer wrote:
>    
>> Just an FYI - 2.6.32.3 with alt 3 af_packet patch&  sky2
>> pskb_may_pull runs OK with DMAR (re)enabled and msi enabled.
>>      
> Hmm... What a pity! It was such a useful debugging tool for
> networking ;-) BTW, I'm not sure if "runs OK" means with or without
> those DHCP drops&  large packets you described.
>
> Thanks,
> Jarek P.
>    
As of now, no errors even when blasting traffic & forcing dhcp packets 
as before. I haven't tried putting mtu back to 9k yet. OK means that 
there are no obvious differences in behavior with or without DMAR all 
else being equal.

There were some updates made to stable that could have fixed this - I'd 
guess intel_iommu fixes helped.

If it helps, I'm still getting one error without DMAR enabled - at 
startup, there's a DMA sync oops - mismatch of 72 bytes coming from 
sky2. That oops was posted previously - with DMAR (re) enabled, there's 
no related oops.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/