linux-kernel - Re: [PATCH -v2 5/5] x86: use dmi check to treat disabled cpus as hotplug cpus.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B4E48BB.5030902@zytor.com>
Date:	Wed, 13 Jan 2010 14:27:07 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Andi Kleen <andi@...stfloor.org>
CC:	Yinghai Lu <yinghai@...nel.org>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"ananth@...ibm.com" <ananth@...ibm.com>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -v2 5/5] x86: use dmi check to treat disabled cpus as
 hotplug cpus.

On 01/13/2010 02:23 PM, Andi Kleen wrote:
>> There are configurations in which percpu memory is in the megabytes.
> 
> There used to be some like this (with some broken debug code), but they
> got all fixed i believe to only allocate on real cpu hotplug. 
> 
> If not the right way is to fix them, not add DMI blacklists.
> 
> Beside when you enable debug code you probably don't care about 
> a few MB too much.
> 
>> This is exactly why we need high water mark allocation of percpu memory:
> 
> No we just need to fix any percpu pigs (if there are really any left,
> I did a couple of patches some time ago)
> 
> "Don't work around broken code -- fix it"
> 

Well, that *is* working around broken code, in this case the broken code
is the percpu allocation strategy.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/