linux-kernel - Re: [RFC PATCH] accouting: account if a task was killed by OOM killer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B4EF92C.5070402@redhat.com>
Date:	Thu, 14 Jan 2010 18:59:56 +0800
From:	Xiaotian Feng <dfeng@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-kernel@...r.kernel.org, Michal Schmidt <mschmidt@...hat.com>,
	David Howells <dhowells@...hat.com>,
	Serge Hallyn <serue@...ibm.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Frans Pop <elendil@...net.nl>
Subject: Re: [RFC PATCH] accouting: account if a task was killed by OOM killer

On 01/14/2010 06:54 AM, Andrew Morton wrote:
> On Mon, 11 Jan 2010 14:40:34 +0800
> Xiaotian Feng<dfeng@...hat.com>  wrote:
>
>> This patch introduces a new accounting flag which is set when a task
>> was killed by OOM killer. taskstats can tell users when a job has been
>> killed by the oomkiller.
>>
>
> Why is this useful?  I'd be looking for a description of some
> operational scenario where this feature is valuable to an operator?
>

users of taskstats need to know if a job is killed by OOM killer, then 
perform some automation jobs or notifications.
But current taskstats logs AXSIG if a job is killed by signal, so users 
will be confused by SIGKILL, SIGTERM or OOM killer.

> The description is incomplete.  The patch also alters the contents of
> the BSD accounting records.  That's a change to an ancient interface
> and needs a bit of exposure and thought.  Is it good to put such a
> highly linux-specific and somewhat linux-version-specific field into
> such a venerable userspace interface?
>
> If we _do_ decide to change the BSD accounting records in this manner
> then presumably a manpage will need to be updated.  A cc to
> linux-api@...r.kernel.org would be appropriate.

The BSD accounting part is not necessary, I just made it same as 
taskstats, we can drop BSD accounting part.

>
> But I'm not very convinced about this whole idea at present, personally.
>
>>   include/linux/acct.h                          |    1 +
>>   include/linux/taskstats.h                     |    2 +-
>>   kernel/acct.c                                 |    2 ++
>>   kernel/tsacct.c                               |    2 ++
>
> I'm a bit surprised that getdelays.c doesn't print ac_flag.
>
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/