linux-kernel - Re: [lm-sensors] [patch] hwmon/amc6821: double unlock bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100114124948.79c9d4d3@hyperion.delvare>
Date:	Thu, 14 Jan 2010 12:49:48 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Dan Carpenter <error27@...il.com>
Cc:	Tomaz Mertelj <tomaz.mertelj@...st.arnes.si>,
	linux-kernel@...r.kernel.org, lm-sensors@...sensors.org
Subject: Re: [lm-sensors] [patch] hwmon/amc6821: double unlock bug

On Thu, 14 Jan 2010 13:30:20 +0300, Dan Carpenter wrote:
> The mutex gets unlocked after we goto EXIT.
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>
> 
> --- orig/drivers/hwmon/amc6821.c	2010-01-14 13:22:23.000000000 +0300
> +++ devel/drivers/hwmon/amc6821.c	2010-01-14 13:22:30.000000000 +0300
> @@ -686,7 +686,6 @@ static ssize_t set_fan1_div(
>  		data->fan1_div = 4;
>  		break;
>  	default:
> -		mutex_unlock(&data->update_lock);
>  		count = -EINVAL;
>  		goto EXIT;
>  	}

Good catch. Applied, thanks.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/