lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100114183054.0b53c351@taxman.wild-wind.fr.eu.org>
Date:	Thu, 14 Jan 2010 18:30:54 +0100
From:	Marc Zyngier <maz@...terjones.org>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	sparclinux@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sparc: leds_resource.end assigned to itself in
 clock_board_probe()

On Thu, 14 Jan 2010 17:55:55 +0100
Roel Kluin <roel.kluin@...il.com> wrote:

> These statements appear redundant.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> Is there any reason to assign this to itself?
> 
> diff --git a/arch/sparc/kernel/central.c b/arch/sparc/kernel/central.c
> index f3b5466..773caf4 100644
> --- a/arch/sparc/kernel/central.c
> +++ b/arch/sparc/kernel/central.c
> @@ -99,7 +99,6 @@ static int __devinit clock_board_probe(struct
> of_device *op, 
>  	p->leds_resource.start = (unsigned long)
>  		(p->clock_regs + CLOCK_CTRL);
> -	p->leds_resource.end = p->leds_resource.end;

I have the feeling that the right fix is to have:

	p->leds_resource.end = p->leds_resource.start;

hence describing a 1 byte region.

	M.
-- 
I'm the slime oozin' out from your TV set...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ