linux-kernel - Re: [PATCH] Logitech G13 driver (fixed cc list --- ignore others)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca2dc2821001141308s5a552447yb887f619231f449@mail.gmail.com>
Date:	Thu, 14 Jan 2010 22:08:07 +0100
From:	Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:	Jaya Kumar <jayakumar.lkml@...il.com>
Cc:	Pavel Machek <pavel@....cz>,
	"Rick L. Vinyard, Jr." <rvinyard@...nmsu.edu>,
	Jiri Kosina <jkosina@...e.cz>, linux-kernel@...r.kernel.org,
	krzysztof.h1@...pl, Andrew Morton <akpm@...ux-foundation.org>,
	linux-usb@...r.kernel.org, Oliver Neukum <oliver@...kum.org>,
	linux-input@...r.kernel.org
Subject: Re: [PATCH] Logitech G13 driver (fixed cc list --- ignore others)

On Tue, Jan 5, 2010 at 1:14 AM, Jaya Kumar <jayakumar.lkml@...il.com> wrote:
> On Tue, Jan 5, 2010 at 6:48 AM, Pavel Machek <pavel@....cz> wrote:
>>
>> Ok, but I guess you should cc auxdisplay people in future.
>
> Hi Pavel,
>
> I just looked at the drivers/auxdisplay directory and got a bit
> confused. The reason I got confused is because auxdisplay is actually
> an fbdev driver but it is outside of the drivers/video directory. It
> looks like there has only been 1 commit and that was for the Samsung
> KS0108 controller. It also sort of uses platform support but the way
> it is abstracted is odd to my thinking. The controller is ks0108, so
> in my mind that would be the code that would be platform independent,
> and then that would use a board specific IO driver to push data (eg:
> parport or gpio or usb). I think in the long term it would probably
> make sense to write a cleaner approach with a drivers/video/ks0108.c
> which is cleanly platform independent (and back within fbdev proper)
> and then a board specific driver in the appropriate location that
> handles the IO.

I wrote long ago the driver(s) and people that reviewed it thought it
was better to keep it outside. I think that if someone else is going
to need ks0108, then I agree: we should write a independent driver.

It should not be hard, it is an easy controller to play with and the
code is already there. I would try to do it; however, I am not sure if
I would be the most appropriate person to code such generic driver, as
I know almost nothing about all drivers/video/* stuff and the ways of
making it truly generic for future video/ users. Still, I will help
gladly.

>
> Thanks,
> jaya
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/