linux-kernel - Re: [PATCH 1/3] mm: page_alloc.c Remove duplicate call to trace_mm_page_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100114144732.6f0f82a6.akpm@linux-foundation.org>
Date:	Thu, 14 Jan 2010 14:47:32 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Li Hong <lihong.hi@...il.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>
Subject: Re: [PATCH 1/3] mm: page_alloc.c Remove duplicate call to
 trace_mm_page_free_direct

On Wed, 13 Jan 2010 22:49:17 +0800
Li Hong <lihong.hi@...il.com> wrote:

> Function 'trace_mm_page_free_direct' is called in function '__free_pages'.
> But it is called again in 'free_hot_page' if order == 0 and produce duplicate
> records in trace file for mm_page_free_direct event. As below:

When naming functions in changelogs you can just use the name of the
function followed by (), such as trace_mm_page_free_direct().  There's
no need to call it "function 'trace_mm_page_free_direct'".

> K-PID    CPU#    TIMESTAMP  FUNCTION
>   gnome-terminal-1567  [000]  4415.246466: mm_page_free_direct: page=ffffea0003db9f40 pfn=1155800 order=0
>   gnome-terminal-1567  [000]  4415.246468: mm_page_free_direct: page=ffffea0003db9f40 pfn=1155800 order=0
>   gnome-terminal-1567  [000]  4415.246506: mm_page_alloc: page=ffffea0003db9f40 pfn=1155800 order=0 migratetype=0 gfp_flags=GFP_KERNEL
>   gnome-terminal-1567  [000]  4415.255557: mm_page_free_direct: page=ffffea0003db9f40 pfn=1155800 order=0
>   gnome-terminal-1567  [000]  4415.255557: mm_page_free_direct: page=ffffea0003db9f40 pfn=1155800 order=0
> 
> This patch removes the first call and add a call to 'trace_mm_page_free_direct'
> in '__free_pages_ok'.
> 
> Signed-off-by: Li Hong <lihong.hi@...il.com>
> ---
>  mm/page_alloc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 4e9f5cc..24344cd 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -582,6 +582,7 @@ static void __free_pages_ok(struct page *page, unsigned int order)
>         int bad = 0;
>         int wasMlocked = __TestClearPageMlocked(page);
>  
> +       trace_mm_page_free_direct(page, order);
>         kmemcheck_free_shadow(page, order);
>  
>         for (i = 0 ; i < (1 << order) ; ++i)
> @@ -2012,7 +2013,6 @@ void __pagevec_free(struct pagevec *pvec)
>  void __free_pages(struct page *page, unsigned int order)
>  {
>         if (put_page_testzero(page)) {
> -               trace_mm_page_free_direct(page, order);

Your email client replaces tabs with spaces.  I can fix that up, but
please do repair that email client.  Documentation/email-clients.txt
has some help for gmail, but it's ugly.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/