linux-kernel - Re: Changelog quality (was Re: [PATCH] uwb: make USB device id constant)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B5023A6.5070100@s5r6.in-berlin.de>
Date:	Fri, 15 Jan 2010 09:13:26 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Andy Isaacson <adi@...apodia.org>
CC:	Julia Lawall <julia@...u.dk>, N??meth M??rton <nm127@...email.hu>,
	David Vrabel <david.vrabel@....com>, linux-usb@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>, cocci@...u.dk
Subject: Re: Changelog quality (was Re: [PATCH] uwb: make USB device id constant)

Andy Isaacson wrote:
> For example, look at 5d66fe92.  The semantic patch is blissfully,
> incredibly clear.  It makes the sun shine down through the clouds, the
> birds sing, and the kzalloc align.  It's 10 lines long and is quite
> intuitive and explanatory.  In that case, I think it's clear that the
> spatch is worth the changelog space it takes up, even though the
> changelog is larger than the diff by quite a margin.

5d66fe92 is another example of what I was talking about.  The changelog
could have read:

	drivers/net : Correct the size argument to kzalloc

	lp->rx_skb is for an array of pointers, not of structs.
	Found using coccinelle.

	Signed-off-by: ...

Tell me again in what way the script is of any importance or of any help
in the permanent SCM changelog after commit.

I agree with you that it is very good to have the script in the patch
posting, but I disagree about the changelog.
-- 
Stefan Richter
-=====-==-=- ---= -====
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/