lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Jan 2010 08:52:12 +0800 From: Li Zefan <lizf@...fujitsu.com> To: H Hartley Sweeten <hartleys@...ionengravers.com> CC: Linux Kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] prio_tree.c: quiet sparse noise H Hartley Sweeten wrote: > prio_tree.c: quiet sparse noise > > The function prio_tree_init is called during start_kernel. Since it > is an __init function it is not exposed as an exported symbol. > A sparse build produces the following warning because of this: > > warning: symbol 'prio_tree_init' was not declared. Should it be static? > > Quiet the warning by declaring the function as an extern before > it's definition. > Why don't you add a declaration of prio_tree_init() to prio_tree.h, and let kernel/main.c include it? > Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com> > > --- > > diff --git a/lib/prio_tree.c b/lib/prio_tree.c > index ccfd850..a677200 100644 > --- a/lib/prio_tree.c > +++ b/lib/prio_tree.c > @@ -68,6 +68,9 @@ static void get_index(const struct prio_tree_root *root, > > static unsigned long index_bits_to_maxindex[BITS_PER_LONG]; > > +/* Keep sparse happy since this is not an EXPORT_SYMBOL */ > +extern void prio_tree_init(void); > + > void __init prio_tree_init(void) > { > unsigned int i; > -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists