lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <175E0F9A9EFCEA46A65F5552BB0572980445DB321C@bgsmsx502.gar.corp.intel.com>
Date:	Fri, 15 Jan 2010 18:49:15 +0530
From:	"Mahalingam, Nithish" <nithish.mahalingam@...el.com>
To:	"avorontsov@...mvista.com" <avorontsov@...mvista.com>
CC:	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	"cbou@...l.ru" <cbou@...l.ru>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [RFC] [PATCH] Adding Intel Moorestown PMIC Battery Driver

>>>> +       unsigned int batt_charge_now;           /* in mAS */
>>>> +       unsigned int batt_prev_charge_full;     /* in mAS */
>>> +       unsigned int batt_charge_rate;          /* in units per second */
>>> 
>>> Per include/linux/power_supply.h and
>>> Documentation/power/power_supply_class.txt
>>> 
>>> * All voltages, currents, charges, energies, time and temperatures in uV,
>>> * uA, uAh, uWh, seconds and tenths of degree Celsius unless otherwise
>>> * stated. It's driver's job to convert its raw values to units in which
>>> * this class operates.
>> 
>> I just now checked the hardware spec and it is indeed mAh. I will correct 
>> the comment appropriately.
> 
> Note, if the hardware reports the values in mAh (milli), the driver
> still have to convert them to uAh (micro) before reporting the values
> to userspace.

Yup will take care, sorry for not making it clear here.


Regards,
Nithish

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ