linux-kernel - Re: [PATCH] typo in kernel source (DEBUGFS)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 15 Jan 2010 17:54:09 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Linus Walleij <linus.ml.walleij@...il.com>,
	Christoph Egger <siccegge@...d.informatik.uni-erlangen.de>,
	linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...ricsson.com>,
	sameo@...ux.intel.com, Reinhard.Tartler@...ormatik.uni-erlangen.de
Subject: Re: [PATCH] typo in kernel source (DEBUGFS)

On Fri, 15 Jan 2010, Jiri Kosina wrote:

> > 2010/1/13 Christoph Egger <siccegge@...d.informatik.uni-erlangen.de>:
> > 
> > >        While working on this we detected a spelling error in
> > > drivers/mfd/ab3100-otp.c which can be corrected using the attached
> > > patch.
> > 
> > Acked-by: Linus Walleij <linus.walleij@...ricsson.com>
> 
> The original patch misses a Signed-off-by. Please resend it to 
> trivial@...nel.org with this line, so that it could be applied.

... and has this been tested at all?

drivers/mfd/ab3100-otp.c: In function ‘show_otp’:
drivers/mfd/ab3100-otp.c:101: error: dereferencing pointer to incomplete type
drivers/mfd/ab3100-otp.c:104: error: implicit declaration of function ‘seq_printf’
drivers/mfd/ab3100-otp.c:102: warning: unused variable ‘err’
drivers/mfd/ab3100-otp.c: In function ‘ab3100_otp_open’:
drivers/mfd/ab3100-otp.c:116: error: implicit declaration of function ‘single_open’
drivers/mfd/ab3100-otp.c:116: error: ‘ab3100_otp_show’ undeclared (first use in this function)
drivers/mfd/ab3100-otp.c:116: error: (Each undeclared identifier is reported only once
drivers/mfd/ab3100-otp.c:116: error: for each function it appears in.)
drivers/mfd/ab3100-otp.c: At top level:
drivers/mfd/ab3100-otp.c:121: error: ‘seq_read’ undeclared here (not in a function)
drivers/mfd/ab3100-otp.c:122: error: ‘seq_lseek’ undeclared here (not in a function)
drivers/mfd/ab3100-otp.c:123: error: ‘single_release’ undeclared here (not in a function)
drivers/mfd/ab3100-otp.c: In function ‘ab3100_otp_init_debugfs’:
drivers/mfd/ab3100-otp.c:134: error: ‘err’ undeclared (first use in this function)
drivers/mfd/ab3100-otp.c: In function ‘ab3100_otp_exit_debugfs’:
drivers/mfd/ab3100-otp.c:140: error: implicit declaration of function ‘debugfs_remove_file’

So looks like the debugfs code might need some more surgery.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/