lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Jan 2010 10:24:59 -0700 From: H Hartley Sweeten <hartleys@...ionengravers.com> To: Linux Kernel <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org Cc: davem@...emloft.net, kuznet@....inr.ac.ru, pekkas@...core.fi, jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net Subject: [PATCH] ipv4/ip_sockglue.c: copy msg_control optval from user to kernel space ipv4/ip_sockglue.c: copy msg_control optval from user to kernel space In do_ip_getsockopt the char __user *optval is used directly in IP_PKTOPTIONS for the msg.msg_control and not copied from user to kernel address space. This produces a sparse warning: warning: incorrect type in assignment (different address spaces) expected void *msg_control got char [noderef] <asn:1>*optval Fix this by using copy _from_user to set msg.msg_control. Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com> Cc: David S. Miller <davem@...emloft.net> Cc: Alexey Kuznetsov <kuznet@....inr.ac.ru> Cc: "Pekka Savola (ipv6)" <pekkas@...core.fi> Cc: James Morris <jmorris@...ei.org> Cc: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org> Cc: Patrick McHardy <kaber@...sh.net> --- diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c index cafad9b..8065456 100644 --- a/net/ipv4/ip_sockglue.c +++ b/net/ipv4/ip_sockglue.c @@ -1173,7 +1173,8 @@ static int do_ip_getsockopt(struct sock *sk, int level, int optname, if (sk->sk_type != SOCK_STREAM) return -ENOPROTOOPT; - msg.msg_control = optval; + if (copy_from_user(msg.msg_control, optval, len)) + return -EFAULT; msg.msg_controllen = len; msg.msg_flags = 0; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists