linux-kernel - Re: [PATCH 05/14] pci: add failed_list to record failed one for pci_bus_assign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B50DA78.6050909@kernel.org>
Date:	Fri, 15 Jan 2010 13:13:28 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
CC:	Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	Alex Chiang <achiang@...com>,
	Bjorn Helgaas <bjorn.helgaas@...com>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH 05/14] pci: add failed_list to record failed one for pci_bus_assign_resources

On 01/15/2010 10:56 AM, Jesse Barnes wrote:
> On Tue, 22 Dec 2009 15:02:25 -0800
> Yinghai Lu <yinghai@...nel.org> wrote:
> 
>> so later we can do sth with those failed one
>>
>> -v2: store start, end, flags aside. so could keep res cleared when
>> assign failed. and make following assignment of its children do not
>> go wild
>>
>> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
>> ---
>>  drivers/pci/setup-bus.c |   66
>> ++++++++++++++++++++++++++++++++++++++++++++--- 1 files changed, 62
>> insertions(+), 4 deletions(-)
> 
> Bjorn's comments still stand here, this patch doesn't make any sense by
> itself.  Either the failed list functions and struct def should stand
> alone, or the whole thing should be rolled into the patch that actually
> makes use of these functions.
> 

just want to make patch to be reviewed easyly.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/