linux-kernel - Re: [PATCH] ACPICA: wrong acpi_parse_state assigned acpi_ps_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d3f22a1001141747p25b3406fv55364be65002546b@mail.gmail.com>
Date:	Fri, 15 Jan 2010 09:47:14 +0800
From:	Lin Ming <lin@...ggr.cn>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPICA: wrong acpi_parse_state assigned 
	acpi_ps_init_scope() ?

On Fri, Jan 15, 2010 at 8:31 AM, Roel Kluin <roel.kluin@...il.com> wrote:
> Assign the package end, not the last AML byte.
>
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> Is this right?
>
> diff --git a/drivers/acpi/acpica/psscope.c b/drivers/acpi/acpica/psscope.c
> index 2feca5c..a8dfe16 100644
> --- a/drivers/acpi/acpica/psscope.c
> +++ b/drivers/acpi/acpica/psscope.c
> @@ -118,7 +118,7 @@ acpi_ps_init_scope(struct acpi_parse_state * parser_state,
>        scope->parse_scope.op = root_op;
>        scope->parse_scope.arg_count = ACPI_VAR_ARGS;
>        scope->parse_scope.arg_end = parser_state->aml_end;
> -       scope->parse_scope.pkg_end = parser_state->aml_end;
> +       scope->parse_scope.pkg_end = parser_state->pkg_end;

->aml_end and ->pkg_end are same here.

acpi_ps_init_scope is only called in acpi_ds_init_aml_walk which set
aml_end and pkg_end the same.

acpi_ds_init_aml_walk(...)
{
    ....
    walk_state->parser_state.aml_end =
            walk_state->parser_state.pkg_end = aml_start + aml_length;
    .....

    status = acpi_ps_init_scope(&walk_state->parser_state, op);
    .....
}

Lin Ming

>
>        parser_state->scope = scope;
>        parser_state->start_op = root_op;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/