[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20100116.012004.166836523.davem@davemloft.net>
Date: Sat, 16 Jan 2010 01:20:04 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: Tristram.Ha@...rel.Com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
shemminger@...tta.com
Subject: Re: [PATCH 2.6.33 1/3] net: Micrel KSZ8841/2 PCI Ethernet driver
From: "Ha, Tristram" <Tristram.Ha@...rel.Com>
Date: Fri, 15 Jan 2010 18:57:59 -0800
> The KSZ8842 has a switch with lots of hardware configurations. The =
> driver uses the proc system to allow users to configure the switch. If =
> this is not desired the whole thing can be removed by not calling the =
> init_proc() function.
I think there needs to be a serious discussion about how
this driver uses bridge layer internals by doing things like:
+/* Needed for STP support. */
+#ifdef CONFIG_KSZ8842_STP
+#include <../net/bridge/br_private.h>
+#endif
and uses procfs to configure the ports.
Stephen please look this over and make suggestions for better
ways to support and configure these kinds of devices.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists