linux-kernel - Re: flash_platform_data namespace collision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 16 Jan 2010 11:23:15 -0800
From:	David Brownell <david-b@...bell.net>
To:	Matt Mackall <mpm@...enic.com>
Cc:	Russell King <rmk+lkml@....linux.org.uk>,
	David Woodhouse <dwmw2@...radead.org>,
	Linux Mailing List <linux-kernel@...r.kernel.org>,
	"linux-embedded" <linux-embedded@...r.kernel.org>
Subject: Re: flash_platform_data namespace collision

On Saturday 16 January 2010, Matt Mackall wrote:
> On Sat, 2010-01-16 at 11:04 +0000, Russell King wrote:
> > On Fri, Jan 15, 2010 at 11:41:15PM -0600, Matt Mackall wrote:
> > > I've got a board here with SPI, NOR, and NAND flash devices and I've
> > > just run into a namespace collision on flash_platform_data from
> > 
> > The one in arch/arm/include/asm/mach/flash.h is designed to have great
> > appeal and flexibility across different platforms, and indeed we have
> > at least 70 users across six different MTD NOR flash drivers and two
> > MTD NAND drivers.

Yet it doesn't do what's needed for SPI flash (identify the chip type,
when it can't probed); and for that application none of those methods
are useful (and their slots are just wasted/confusing space).


> > If anything, I believe that this header should move into linux/mtd/
> > and become a standard structure for platforms to communicate their
> > requirements to flash drivers.
> 
> Yeah, I think this is probably the way to go. Davids, any objections?

I had similar thoughts when I first happened across that structure.

But such a move wouldn't resolve $SUBJECT ... which is IMO best addressed
by the obvious rename of the one to spi_flash_platform_data.

- dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/