linux-kernel - Re: [PATCH] acpi: Fix unused variable warning in sbs.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <alpine.LFD.2.00.1001161602070.7124@localhost.localdomain>
Date:	Sat, 16 Jan 2010 16:03:03 -0500 (EST)
From:	Len Brown <lenb@...nel.org>
To:	Alexey Starikovskiy <astarikovskiy@...e.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Rakib Mullick <rakib.mullick@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] acpi: Fix unused variable warning in sbs.c

On Sat, 9 Jan 2010, Alexey Starikovskiy wrote:

> Andrew Morton пишет:
> > I wonder if it can be fixed in Kconfig.  Is there any sane use of
> > this code when CONFIG_ACPI_SYSFS_POWER=n && CONFIG_ACPI_PROCFS_POWER=n?

> No, this driver is useless in such a case. It can not output any info (and this is all it does).


Hi Alex,
Probably the code can lose some ifdefs by doing things
like making acpi_battery_remove_fs() a static inline when 
!CONFIG_ACPI_PROCFS_POWER.

cheers,
-Len