linux-kernel - [tip:perf/urgent] hw-breakpoints, perf: Fix broken mmiotrace due to dr6 by reference change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-0bb7a95f5455cd87e6a69e5818bc1f509a98d187@git.kernel.org>
Date:	Sun, 17 Jan 2010 18:30:32 GMT
From:	tip-bot for Luca Barbieri <luca@...a-barbieri.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	fweisbec@...il.com, luca@...a-barbieri.com, tglx@...utronix.de,
	prasad@...ux.vnet.ibm.com, mingo@...e.hu
Subject: [tip:perf/urgent] hw-breakpoints, perf: Fix broken mmiotrace due to dr6 by reference change

Commit-ID:  0bb7a95f5455cd87e6a69e5818bc1f509a98d187
Gitweb:     http://git.kernel.org/tip/0bb7a95f5455cd87e6a69e5818bc1f509a98d187
Author:     Luca Barbieri <luca@...a-barbieri.com>
AuthorDate: Sat, 16 Jan 2010 10:39:30 +0100
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Sun, 17 Jan 2010 08:01:44 +0100

hw-breakpoints, perf: Fix broken mmiotrace due to dr6 by reference change

Commit 62edab9056a6cf0c9207339c8892c923a5217e45 (from June 2009
but merged in 2.6.33) changes notify_die to pass dr6 by
reference.

However, it forgets to fix the check for DR_STEP in kmmio.c,
breaking mmiotrace. It also passes a wrong value to the post
handler.

This simple fix makes mmiotrace work again.

Signed-off-by: Luca Barbieri <luca@...a-barbieri.com>
Acked-by: K.Prasad <prasad@...ux.vnet.ibm.com>
Cc: Frederic Weisbecker <fweisbec@...il.com>
LKML-Reference: <1263634770-14578-1-git-send-email-luca@...a-barbieri.com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/x86/mm/kmmio.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/x86/mm/kmmio.c b/arch/x86/mm/kmmio.c
index c0f6198..536fb68 100644
--- a/arch/x86/mm/kmmio.c
+++ b/arch/x86/mm/kmmio.c
@@ -538,14 +538,15 @@ static int
 kmmio_die_notifier(struct notifier_block *nb, unsigned long val, void *args)
 {
 	struct die_args *arg = args;
+	unsigned long* dr6_p = (unsigned long *)ERR_PTR(arg->err);
 
-	if (val == DIE_DEBUG && (arg->err & DR_STEP))
-		if (post_kmmio_handler(arg->err, arg->regs) == 1) {
+	if (val == DIE_DEBUG && (*dr6_p & DR_STEP))
+		if (post_kmmio_handler(*dr6_p, arg->regs) == 1) {
 			/*
 			 * Reset the BS bit in dr6 (pointed by args->err) to
 			 * denote completion of processing
 			 */
-			(*(unsigned long *)ERR_PTR(arg->err)) &= ~DR_STEP;
+			*dr6_p &= ~DR_STEP;
 			return NOTIFY_STOP;
 		}
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/