lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 17 Jan 2010 08:12:27 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Roel Kluin <roel.kluin@...il.com>, Cliff Wickman <cpw@....com>,
	Robin Holt <holt@....com>, Mike Travis <travis@....com>
Cc:	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: bau_msg_head points to a_queue_first in
 uv_table_bases_finish()


* Roel Kluin <roel.kluin@...il.com> wrote:

> bau_msg_head should point to bau_msg_head
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> Is this correct?
> 
> diff --git a/arch/x86/kernel/tlb_uv.c b/arch/x86/kernel/tlb_uv.c
> index 364d015..3d66331 100644
> --- a/arch/x86/kernel/tlb_uv.c
> +++ b/arch/x86/kernel/tlb_uv.c
> @@ -691,7 +691,7 @@ uv_table_bases_finish(int blade,
>  			continue;
>  
>  		bcp = (struct bau_control *)&per_cpu(bau_control, cpu);
> -		bcp->bau_msg_head	= bau_tablesp->va_queue_first;
> +		bcp->bau_msg_head	= bau_tablesp->bau_msg_head;
>  		bcp->va_queue_first	= bau_tablesp->va_queue_first;
>  		bcp->va_queue_last	= bau_tablesp->va_queue_last;
>  		bcp->msg_statuses	= bau_tablesp->msg_statuses;

Seems like you either caught a real bug - or that there's a somewhat quirky 
initialization sequence here which should be commented upon in the source.

Cliff, Robin, what's your take on Roel's patch?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists