linux-kernel - Re: [PATCH 14/26] trace: Convert various locks to raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100117130044.GE5035@nowhere>
Date:	Sun, 17 Jan 2010 14:00:46 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	John Kacur <jkacur@...hat.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	lkml <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Clark Williams <williams@...hat.com>
Subject: Re: [PATCH 14/26] trace: Convert various locks to raw_spinlock

On Wed, Jan 13, 2010 at 07:09:22PM +0100, John Kacur wrote:
> 
> 
> On Wed, 13 Jan 2010, Steven Rostedt wrote:
> 
> > On Wed, 2010-01-13 at 16:36 +0100, John Kacur wrote:
> > > 
> > > On Wed, 13 Jan 2010, Steven Rostedt wrote:
> > 
> > > > 
> > > Thanks for the review Steve and Frederic - I'll spin a new patch that 
> > > doesn't convert tracing_start_lock.
> > > 
> > > However, let's give it some good testing in preempt-rt, because we may 
> > > have forgotten over time, why we converted these locks.
> > 
> > Well, I think we just never unconverted them :-)  I think we took the
> > paranoid approach and converted all locks in the trace directory to raw.
> > In fact, I think I even had a script to do it.
> > 
> > -- Steve
> 
> Okay, here is the new version of the patch.
> Frederic and Steve, can I have Acked-bys before I push to git?
> 
> Thanks
> 
> From ee03cc607493e58f34bf93afa2b8a23da5510927 Mon Sep 17 00:00:00 2001
> From: John Kacur <jkacur@...hat.com>
> Date: Sun, 10 Jan 2010 03:09:48 +0100
> Subject: [PATCH] trace: Convert reader_lock and max_trace_lock to raw_spinlocks
> 
> Convert reader_lock and max_trace_lock to raw_spinlock.
> These locks cannot sleep in preempt-rt because they are called with
> interrupts disabled. This should have zero-impact on mainline.
> 
> See also: 87654a70523a8c5baadcbbc07d80cbae8f912837
> 
> Signed-off-by: John Kacur <jkacur@...hat.com>



Acked-by: Frederic Weisbecker <fweisbec@...il.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/