linux-kernel - RE: [PATCH 1/1] atmel uaba : Adding invert vbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B5E0EDE940845B429B7ECCE186529F2C0641D181F7@dware2702>
Date:	Mon, 18 Jan 2010 08:02:46 +0100
From:	Eirik Aanonsen <EAA@...medical.com>
To:	Greg KH <greg@...ah.com>
CC:	"kernel@...32linux.org" <kernel@...32linux.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/1] atmel uaba : Adding invert vbus_pin

> 
> On Mon, Jan 04, 2010 at 02:01:59PM +0100, Eirik Aanonsen wrote:
> > Adding vbus_pin_inverted so that the usb detect pin can be active
> high or low.
> > This because depending on HW implementation it is better to have
> active low.
> > Also replaced the pio_get_value(udc->vbus_pin); with a call to
> vbus_is_present(udc);
> >
> > Signed-off-by: Eirik Aanonsen <eaa@...medical.com>
> 
> Please always run your patches through 'scripts/checkpatch.pl' before
> sending them so that you don't accidentally add coding style errors.
> 
> thanks,
> 
> greg k-h

Yes I'm sorry I got that feedback from several others as well.

That is why I resubmitted the patch on 05.Jan. But under the same name, and since then I have not received any feedback on that patch.

***
Snip from local:

./scripts/checkpatch.pl 0014-Adding-vbus_pin_inverted-so-that-the-usb-detect-pin.patch 
total: 0 errors, 0 warnings, 38 lines checked

0014-Adding-vbus_pin_inverted-so-that-the-usb-detect-pin.patch has no obvious style problems and is ready for submission.
***

Best regards
____________________________________________________
 
Eirik Aanonsen
SW Developer
E-mail: eaa@...medical.com 
Phone: +47 90 68 11 92
Fax: +47 37 03 56 77
____________________________________________________



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/