linux-kernel - Re: [PATCH] oom: OOM-Killed process don't invoke pagefault-oom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100118072946.GA10052@laptop>
Date:	Mon, 18 Jan 2010 18:29:46 +1100
From:	Nick Piggin <npiggin@...e.de>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	Jeff Dike <jdike@...toit.com>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-mm <linux-mm@...ck.org>
Subject: Re: [PATCH] oom: OOM-Killed process don't invoke pagefault-oom

On Fri, Jan 15, 2010 at 03:21:40PM +0900, KOSAKI Motohiro wrote:
> > Hi,
> > 
> > I don't think this should be required, because the oom killer does not
> > kill a new task if there is already one in memdie state.
> > 
> > If you have any further tweaks to the heuristic (such as a fatal signal
> > pending), then it should probably go in select_bad_process() or
> > somewhere like that.
> 
> I see, I misunderstood. very thanks.

Well, it *might* be a good idea to check for fatal signal pending
similar your patch. Because I think there could be large latency between
the signal and the task moving to exit state if the process is waiting
uninterruptible in the kernel for a while.

But if you do it in select_bad_process() then it would work for all
classes of oom kill.

Thanks,
Nick

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/