linux-kernel - Re: [PATCH 39/40] gfs2: use workqueue instead of slow-work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B5444FD.4050500@kernel.org>
Date:	Mon, 18 Jan 2010 20:24:45 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Steven Whitehouse <swhiteho@...hat.com>
CC:	torvalds@...ux-foundation.org, mingo@...e.hu, peterz@...radead.org,
	awalls@...ix.net, linux-kernel@...r.kernel.org, jeff@...zik.org,
	akpm@...ux-foundation.org, jens.axboe@...cle.com,
	rusty@...tcorp.com.au, cl@...ux-foundation.org,
	dhowells@...hat.com, arjan@...ux.intel.com, avi@...hat.com,
	johannes@...solutions.net, andi@...stfloor.org
Subject: Re: [PATCH 39/40] gfs2: use workqueue instead of slow-work

On 01/18/2010 06:45 PM, Steven Whitehouse wrote:
> Hi,
> 
> On Mon, 2010-01-18 at 09:57 +0900, Tejun Heo wrote:
>> Workqueue can now handle high concurrency.  Use system_long_wq instead
>> of slow-work.
>>
>> Signed-off-by: Tejun Heo <tj@...nel.org>
>> Cc: Steven Whitehouse <swhiteho@...hat.com>
> 
> Acked-by: Steven Whitehouse <swhiteho@...hat.com> on two conditions:
> 
>  i) That scheduling work on this new workqueue will not require any
> GFP_KERNEL allocations (even hidden ones such as starting new threads)
> before the work runs. This is required since the recovery code must not
> call into the fs until after its recovered.

Oh, if that's the case, it needs its own wq with a rescuer.  I thought
the recovery path wasn't invoked during allocation.  slow-work didn't
guarantee such thing either.  Anyways, changing that is pretty easy.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/