linux-kernel - Re: [PATCH 1/1] Constify struct sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100118013521.GA4190@suse.de>
Date:	Sun, 17 Jan 2010 17:35:21 -0800
From:	Greg KH <gregkh@...e.de>
To:	Emese Revfy <re.emese@...il.com>
Cc:	Al Viro <viro@...IV.linux.org.uk>, linux-kernel@...r.kernel.org,
	teigland@...hat.com, Matt_Domsch@...l.com,
	maciej.sosnowski@...el.com, hjk@...utronix.de,
	Pekka Enberg <penberg@...helsinki.fi>, jens.axboe@...cle.com,
	shemminger@...tta.com, akpm@...ux-foundation.org,
	davem@...emloft.net, torvalds@...ux-foundation.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] Constify struct sysfs_ops for v2.6.33-rc4

On Sun, Jan 17, 2010 at 09:15:49PM +0100, Emese Revfy wrote:
> Al Viro wrote:
> > On Sun, Jan 17, 2010 at 05:20:38PM +0100, Emese Revfy wrote:
> > 
> >> Signed-off-by: Emese Revfy <re.emese@...il.com>
> >> Acked-by: David Teigland <teigland@...hat.com>
> >> Acked-by: Matt Domsch <Matt_Domsch@...l.com>
> >> Acked-by: Maciej Sosnowski <maciej.sosnowski@...el.com>
> >> Acked-by: Hans J. Koch <hjk@...utronix.de>
> >> Acked-by: Pekka Enberg <penberg@...helsinki.fi>
> >> Acked-by: Jens Axboe <jens.axboe@...cle.com>
> >> Acked-by: Stephen Hemminger <shemminger@...tta.com>
> > 
> > NACKed-by: Al Viro <viro@...iv.linux.org.uk>
> > 
> > Same reason.
> > 
> >> -        ssize_t (*show)(struct kobject *, struct attribute *, char *);
> >> -        ssize_t (*store)(struct kobject *, struct attribute *, const char *);
> >> +        ssize_t (* const show)(struct kobject *, struct attribute *, char *);
> >> +        ssize_t (* const store)(struct kobject *, struct attribute *, const char *);
> > 
> 
> Ok, I removed the field constification, here's the updated patch:

Please resend with proper changelog and other information so that it
could be applied.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/