linux-kernel - Re: [PATCH] video/matrox: Checkpatch cleanups for matroxfb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jan 2010 20:27:29 +0100
From:	Peter Hüwe <PeterHuewe@....de>
To:	Joe Perches <joe@...ches.com>
Cc:	Petr Vandrovec <vandrove@...cvut.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jean Delvare <khali@...ux-fr.org>,
	Krzysztof Helt <krzysztof.h1@...pl>,
	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] video/matrox: Checkpatch cleanups for matroxfb_crtc2.c

Am Montag 18 Januar 2010 20:17:49 schrieb Joe Perches:
> On Mon, 2010-01-18 at 19:34 +0100, Peter Hüwe wrote:
> > From: Peter Huewe <peterhuewe@....de>
> > Date: Mon, 18 Jan 2010 19:21:02 +0100
> > This patch fixes all 77 errors reported by checkpatch - no functional
> > change was made. The line over 80 chars warnings were left untouched.
> > diff --git a/drivers/video/matrox/matroxfb_crtc2.c
> > b/drivers/video/matrox/matroxfb_crtc2.c index 78414ba..790ca47 100644
> > --- a/drivers/video/matrox/matroxfb_crtc2.c
> > +++ b/drivers/video/matrox/matroxfb_crtc2.c
> > @@ -42,42 +43,41 @@ static int matroxfb_dh_setcolreg(unsigned regno,
> > unsigned red, unsigned green, blue = CNVT_TOHW(blue,
> > m2info->fbcon.var.blue.length);
> >  	transp = CNVT_TOHW(transp, m2info->fbcon.var.transp.length);
> >
> > -	col = (red << m2info->fbcon.var.red.offset)     |
> > -	      (green << m2info->fbcon.var.green.offset) |
> > -	      (blue << m2info->fbcon.var.blue.offset)   |
> > -	      (transp << m2info->fbcon.var.transp.offset);
> > +	col =	(red << m2info->fbcon.var.red.offset)		|
> > +			(green << m2info->fbcon.var.green.offset)	|
> > +			(blue << m2info->fbcon.var.blue.offset)		|
> > +			(transp << m2info->fbcon.var.transp.offset);
> 
> I think this is not an improvement.
> 

Hi,
the reason behind this change was that spaces and tabs were mixed for 
indention. 



-       col =   (red << m2info->fbcon.var.red.offset)           |
-                       (green << m2info->fbcon.var.green.offset)       |
-                       (blue << m2info->fbcon.var.blue.offset)         |
-                       (transp << m2info->fbcon.var.transp.offset);
+       col = (red << m2info->fbcon.var.red.offset)             |
+               (green << m2info->fbcon.var.green.offset)       |
+               (blue << m2info->fbcon.var.blue.offset)         |
+               (transp << m2info->fbcon.var.transp.offset);

How about this indention? Would this be better?

I'll wait for your response and wrap up the other changes then and resubmit 
it.


Thanks for your comments!

Peter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/