linux-kernel - Re: mcs7830 usb net: "scheduling while atomic" danger?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1001182238010.2906@localhost.localdomain>
Date:	Mon, 18 Jan 2010 22:38:34 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Julia Lawall <julia@...u.dk>
cc:	Andreas Mohr <andi@...as.de>, linux-kernel@...r.kernel.org,
	Greg KH <greg@...ah.com>
Subject: Re: mcs7830 usb net: "scheduling while atomic" danger?

On Mon, 18 Jan 2010, Julia Lawall wrote:
> On Mon, 18 Jan 2010, Thomas Gleixner wrote:
> 
> > Julia,
> > 
> > On Mon, 18 Jan 2010, Julia Lawall wrote:
> > > On Mon, 18 Jan 2010, Andreas Mohr wrote:
> > >
> > > The semantic match shown below finds 55 matches.  All but two involve 
> > > mutex_lock.  Those are in the file 
> > 
> > As I said before the mutex_lock()/msleep() ones are fine. 
> 
> OK, I sem to have missed that message.
> 
> > > /var/linuxes/linux-next/drivers/usb/host/ehci-hub.c
> > > in the functions ehci_bus_suspend and ehci_hub_control.
> > 
> > The msleep in ehci_hub_control() which happens with ehci->lock held
> > and irqs disabled is definitely buggy.
> > 
> > I can't see anything wrong wth the msleep in ehci_bus_suspend() as it
> > is _before_ the spin_lock_irq(&ehci->lock) region.
> 
> There is another one later in the function:
> 
> msleep(5);/* 5ms for HCD enter low pwr mode */
> 
> In my linux-next, it is on line 181.

Ooops, missed that one. Right, that's buggy as well.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/