linux-kernel - Re: [PATCH] Add Linux Driver for Intel Langwell Watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100118222400.2b8fa0c2@lxorguk.ukuu.org.uk>
Date:	Mon, 18 Jan 2010 22:24:00 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Mark Allyn <mark.a.allyn@...el.com>
Cc:	linux-kernel@...r.kernel.org, greg@...ah.com, alan@...ux.intel.com,
	charles.f.johnson@...el.com, Mark Allyn <mark.a.allyn@...el.com>
Subject: Re: [PATCH] Add Linux Driver for Intel Langwell Watchdog

> +	/* send the threshold and soft_threshold via IPC to the Lincroft */
> +	reg_data.payload1 = watchdog_device.soft_threshold;
> +	reg_data.payload2 = watchdog_device.threshold;
> +	ipc_set_watchdog(&reg_data);

That still doesn't seem to be merged upstream - someone needs poking to
at least get an IPC driver into staging.


> + * /dev/watchdog handling
> + */
> +static int langwell_open(struct inode *inode, struct file *file)
> +{
> +	/* Miscdevice structure pointer already saved in private_data */
> +
> +	struct watchdog_reg_data reg_data;
> +
> +	if (!capable(CAP_SYS_ADMIN))
> +		return -EPERM;

File permissions will deal with that bit

> +
> +	if (test_and_set_bit(0, &watchdog_device.driver_open))
> +		return -ENOTTY;

EBUSY

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/