linux-kernel - Re: [PATCH] delay-accounting: Re-implement -c for getdelays.c to report information on a target command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B560213.2020707@linux.vnet.ibm.com>
Date:	Wed, 20 Jan 2010 00:33:47 +0530
From:	Balbir Singh <balbir@...ux.vnet.ibm.com>
To:	Mel Gorman <mel@....ul.ie>
CC:	Alexey Dobriyan <adobriyan@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] delay-accounting: Re-implement -c for getdelays.c to
 report information on a target command

On Wednesday 20 January 2010 12:22 AM, Mel Gorman wrote:
>>
>> That is an oversight and not intentional. I've not gotten around to
>> reimplementing the -c option due to lack for people asking for it.
>>
> 
> Consider this a request then. Man, I'd really like if someone
> implemented that -c switch thing :P
> 

:)

>>> This patch reimplements -c for getdelays.c to act as documented. Unlike the
>>> original version, it waits until the command completes before printing any
>>> information on it. An example of it being used looks like
>>>
>>
>> Looks good, could you please keep the original sign-offs as well?
>>
> 
> Well, the reimplementation is significantly different to what was there
> so I'm not sure that's appropriate. Look at the differences yourself.
> 

Fair enough

>>> $ ./getdelays -d -c find /home/mel -name mel
>>> print delayacct stats ON
>>> /home/mel
>>> /home/mel/.notes-wine/drive_c/windows/profiles/mel
>>> /home/mel/.wine/drive_c/windows/profiles/mel
>>> /home/mel/git-configs/dot.kde/share/apps/konqueror/home/mel
>>> PID	5923
>>>
>>> CPU             count     real total  virtual total    delay total
>>>                 42779     5051232096     5164722692      564207988
>>> IO              count    delay total
>>>                 41727    97804147758
>>> SWAP            count    delay total
>>>                     0              0
>>> RECLAIM         count    delay total
>>>                     0              0
>>>
>>> It's not clear how or if this subsystem is being maintained. If the
>>> authors agree on it but do not pick it up for merging, I'll go bug
>>> Andrew with it.
>>>
>>
>> I am maintaining it, please do let me know if you have an issue with the
>> subsystem or utilities.
>>
> 
> If you're happy with the patch then, can you pick it up, add your
> signed-off-by and go with whatever submission path you use for this
> subsystem?
> 

Absolutely!

Signed-off-by: Balbir Singh <balbir@...ux.vnet.ibm.com>

Andrew, could you please pick this up?

Thanks,
Balbir Singh.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/