linux-kernel - Re: [PATCH] Backport of Sierra Wireless USB serial driver from 2.6 to kernel 2.4.37

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100119192626.GA31490@kroah.com>
Date:	Tue, 19 Jan 2010 11:26:26 -0800
From:	Greg KH <greg@...ah.com>
To:	David Holm <dholmster@...il.com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux@...rrawireless.com, klloyd@...rrawireless.com
Subject: Re: [PATCH] Backport of Sierra Wireless USB serial driver from 2.6
 to kernel 2.4.37

On Tue, Jan 19, 2010 at 08:19:40PM +0100, David Holm wrote:
> This is a backport of the Sierra Wireless USB modem from
> linux/kernel/git/torvalds/linux-2.6.git to kernel 2.4. We are actively
> using this driver on our embedded systems running uClinux 2.4.26 on an
> ARM7TDMI but the patch has been produced against 2.4.37. I did not
> have time to prepare and run the entire 2.4.37 on our platform but I
> did backport usbserial.c just to make sure that there woudln't be any
> obvious problems. Hence, if anyone owns a Sierra Wireless modem and is
> running 2.4.37 please help me double check that there are no hidden
> surprises.
> The driver has been run extensively with usbserial and sierra
> debugging turned on. I've also done some tests with debugging enabled
> in the USB subsystem but this was the first time ever that I had to
> code a driver for a USB device so those message were usually of
> limited help to me.
> 
> I've tried to retain formatting of the 2.6 code as much as possible to
> make it easier to diff against newer revisions. This also means that I
> intentionally did not fix code guideline errors in that code. The
> portions that I have written myself should follow the guidelines
> though.
> 
> The power management code was removed completely due to lack of
> support in 2.4. Other than that I believe I was able to retain all of
> the remaining functionality. We only have access to the Sierra
> Wireless Compass 889 at work so that is the only hardware I've been
> running it against but the only hardware that seems to need special
> handling are the "direct IP modems" and that code should still be in
> there untouched.
> 
> I'm pretty sure "sierra_intf_private" as well as the variable "opened"
> in the "sierra_port_private" struct can be removed completely but I
> left them in for now.
> 
> Even though I've worked on a couple of Linux projects before this is
> my first submission so please be gentle. Any feedback will be greatly
> appreciated.

Minor complaint, your email client wrapped the patch, so it would have
to be edited by hand in order to apply it.

Main question though is, why did you do this?  Is there some reason you
are stuck with such an old, and unsupported kernel version that you
required this driver?  What is keeping you from moving to a 2.6 kernel
on this hardware platform, and can we help you out with that in any way?

Otherwise, looks fine at first glance, but I don't know what to do with
the patch as no one is doing 2.4 work upstream anymore except for
security and other minor bugfixes.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/