linux-kernel - RE: [PATCH/RFC v1 0/2] Human readable performance event description in sysfs

Open Source and information security mailing list archives

Message-id: <023f01ca99ba$61ce7e90$256b7bb0$%fujak@samsung.com>
Date:	Wed, 20 Jan 2010 11:21:51 +0100
From:	Tomasz Fujak <t.fujak@...sung.com>
To:	'Russell King - ARM Linux' <linux@....linux.org.uk>
Cc:	jpihet@...sta.com, peterz@...radead.org,
	Pawel Osciak <p.osciak@...sung.com>, jamie.iles@...ochip.com,
	will.deacon@....com, linux-kernel@...r.kernel.org,
	kyungmin.park@...sung.com, mingo@...e.hu,
	linux-arm-kernel@...ts.infradead.org,
	Marek Szyprowski <m.szyprowski@...sung.com>
Subject: RE: [PATCH/RFC v1 0/2] Human readable performance event description in
 sysfs

> -----Original Message-----
> From: linux-arm-kernel-bounces@...ts.infradead.org [mailto:linux-arm-
> kernel-bounces@...ts.infradead.org] On Behalf Of Russell King - ARM
> Linux
> Sent: Wednesday, January 20, 2010 10:58 AM
> To: Tomasz Fujak
> Cc: jpihet@...sta.com; peterz@...radead.org; p.osciak@...sung.com;
> jamie.iles@...ochip.com; will.deacon@....com; linux-
> kernel@...r.kernel.org; kyungmin.park@...sung.com; mingo@...e.hu;
> linux-arm-kernel@...ts.infradead.org; m.szyprowski@...sung.com
> Subject: Re: [PATCH/RFC v1 0/2] Human readable performance event
> description in sysfs
> 
> On Wed, Jan 20, 2010 at 10:11:44AM +0100, Tomasz Fujak wrote:
> > The following patches provide a sysfs entry with hardware event human
> > readable description in the form of "0x%llx\t%lld-%lld\t%s\t%s" %
> > (event_value, minval, maxval, name, description)
> 
> I think your patch is in violation of this from
> Documentation/filesystems/sysfs.txt:
> 
> Attributes
> ~~~~~~~~~
> ...
> Attributes should be ASCII text files, preferably with only one value
> per file. It is noted that it may not be efficient to contain only one
> value per file, so it is socially acceptable to express an array of
> values of the same type.
> 
> Mixing types, expressing multiple lines of data, and doing fancy
> formatting of data is heavily frowned upon. Doing these things may get
> you publically humiliated and your code rewritten without notice.

1. There are numerous exceptions:
$ find /sys -exec grep -HC ^ {} \; 2>/dev/null | grep ":[3-9]$" | grep -c
yielded 43 on my machine.
Some of them list multiple lines with fancy formatting each (i.e.:
/sys/class/Bluetooth/l2cap or devices/pci*/resource)

2. There are sysfs entries regarding the performance counters already:
'overcommit' and 'reserve_percpu'
They are simple, I admit, but I find it useful to have all relevant thing in
one place.

If the above does not convince you, I could move the file to the debugfs.

> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives