linux-kernel - Re: [PATCH] asm-generic: dma: Add BUG_ON for uninitialized dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6fcc0a1001200248x1a4b3cedoae90b4f1495d2358@mail.gmail.com>
Date:	Wed, 20 Jan 2010 12:48:17 +0200
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	monstr@...str.eu
Cc:	linux-kernel@...r.kernel.org, michal.simek@...alogix.com,
	arnd@...db.de, linux-arch@...r.kernel.org,
	fujita.tomonori@....ntt.co.jp, akpm@...ux-foundation.org,
	mingo@...e.hu, joerg.roedel@....com
Subject: Re: [PATCH] asm-generic: dma: Add BUG_ON for uninitialized dma_ops

On Wed, Jan 20, 2010 at 12:08 PM,  <monstr@...str.eu> wrote:
> From: Michal Simek <monstr@...str.eu>
>
> Check that dma_ops are initialized correctly. Without this
> checking you get kernel fault and you don't know where the problem is.

Oh, yes you do. PC will be of some small value.

> +       BUG_ON(!ops);
>        BUG_ON(!valid_dma_direction(dir));
>        addr = ops->map_page(dev, virt_to_page(ptr),
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/