linux-kernel - Re: [PATCH] asm-generic: dma: Add BUG_ON for uninitialized dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10f740e81001200300o217b955fqb79d5628b2e62731@mail.gmail.com>
Date:	Wed, 20 Jan 2010 12:00:31 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	monstr@...str.eu, linux-kernel@...r.kernel.org,
	michal.simek@...alogix.com, arnd@...db.de,
	linux-arch@...r.kernel.org, fujita.tomonori@....ntt.co.jp,
	akpm@...ux-foundation.org, mingo@...e.hu, joerg.roedel@....com
Subject: Re: [PATCH] asm-generic: dma: Add BUG_ON for uninitialized dma_ops

On Wed, Jan 20, 2010 at 11:48, Alexey Dobriyan <adobriyan@...il.com> wrote:
> On Wed, Jan 20, 2010 at 12:08 PM,  <monstr@...str.eu> wrote:
>> From: Michal Simek <monstr@...str.eu>
>>
>> Check that dma_ops are initialized correctly. Without this
>> checking you get kernel fault and you don't know where the problem is.
>
> Oh, yes you do. PC will be of some small value.

And the backtrace will tell you where to look...

>> +       BUG_ON(!ops);
>>        BUG_ON(!valid_dma_direction(dir));
>>        addr = ops->map_page(dev, virt_to_page(ptr),

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/