linux-kernel - Re: Generic DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B56E66C.50004@monstr.eu>
Date:	Wed, 20 Jan 2010 12:18:04 +0100
From:	Michal Simek <monstr@...str.eu>
To:	Joerg Roedel <joerg.roedel@....com>
CC:	linux-kernel@...r.kernel.org, michal.simek@...alogix.com,
	arnd@...db.de, linux-arch@...r.kernel.org,
	fujita.tomonori@....ntt.co.jp, akpm@...ux-foundation.org,
	mingo@...e.hu
Subject: Re: Generic DMA - BUG_ON

Joerg Roedel wrote:
> On Wed, Jan 20, 2010 at 10:53:50AM +0000, Russell King wrote:
>> and ops is NULL, then this code will oops; you will get a full register
>> dump and backtrace.  You can use this information along with markup_oops.pl
>> to find out where the problem is.
> 
> You can't rely on the oops if the code runs in process context. The
> process may have address 0 mapped which would result in a security hole.
> We had two of these bugs last year.

That's the same problem which I had some days ago and Microblaze misses 
valuable backtrace (because we don't have FP or constant frame size).

> 
> But I don't see any point in checking for dma_ops != NULL too. Any
> developer would mention such a bug long before init is started.

I agree that checking adds extra cycles to every dma-api call.

I like as wrote Russel to check if ops exists or not.

Let's look at code which is there.
dma_map_single_attrs - calls ops->map_page without any checking
The same for dma_map_sg_attrs, dma_map_page

The rest of functions is ok. If any checking will be there, I don't have 
any problem with it.

Michal




> 
> 	Joerg
> 
> 


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/