linux-kernel - Re: [PATCH] cx23885: Wrong command printed in cmd_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <83bcf6341001200500h24cb3238rfee89297dae7f8f1@mail.gmail.com>
Date:	Wed, 20 Jan 2010 08:00:16 -0500
From:	Steven Toth <stoth@...nellabs.com>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	linux-media@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cx23885: Wrong command printed in cmd_to_str()

Thanks Roel.

Acked-By: Steven Toth <stoth@...nellabs.com>

- Steve

-- 
Steven Toth - Kernel Labs
http://www.kernellabs.com

On Tue, Jan 19, 2010 at 7:47 PM, Roel Kluin <roel.kluin@...il.com> wrote:
> The wrong command was printed for case CX2341X_ENC_SET_DNR_FILTER_MODE,
> and a typo in case CX2341X_ENC_SET_PCR_ID.
>
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> Or is this intended?
>
> diff --git a/drivers/media/video/cx23885/cx23885-417.c b/drivers/media/video/cx23885/cx23885-417.c
> index 88c0d24..2ab97ad 100644
> --- a/drivers/media/video/cx23885/cx23885-417.c
> +++ b/drivers/media/video/cx23885/cx23885-417.c
> @@ -681,7 +681,7 @@ static char *cmd_to_str(int cmd)
>        case CX2341X_ENC_SET_VIDEO_ID:
>                return  "SET_VIDEO_ID";
>        case CX2341X_ENC_SET_PCR_ID:
> -               return  "SET_PCR_PID";
> +               return  "SET_PCR_ID";
>        case CX2341X_ENC_SET_FRAME_RATE:
>                return  "SET_FRAME_RATE";
>        case CX2341X_ENC_SET_FRAME_SIZE:
> @@ -693,7 +693,7 @@ static char *cmd_to_str(int cmd)
>        case CX2341X_ENC_SET_ASPECT_RATIO:
>                return  "SET_ASPECT_RATIO";
>        case CX2341X_ENC_SET_DNR_FILTER_MODE:
> -               return  "SET_DNR_FILTER_PROPS";
> +               return  "SET_DNR_FILTER_MODE";
>        case CX2341X_ENC_SET_DNR_FILTER_PROPS:
>                return  "SET_DNR_FILTER_PROPS";
>        case CX2341X_ENC_SET_CORING_LEVELS:
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Steven Toth - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/