lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100120153000.GA13172@cmpxchg.org>
Date:	Wed, 20 Jan 2010 16:30:00 +0100
From:	Johannes Weiner <hannes@...xchg.org>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Ralf Baechle <ralf@...ux-mips.org>, x86@...nel.org
Subject: Re: [RFC 1/1] bootmem: move big allocations behing 4G

Hi Jiri,

On Wed, Jan 20, 2010 at 02:50:13PM +0100, Jiri Slaby wrote:
> On 01/19/2010 03:33 PM, Johannes Weiner wrote:
> > --- a/include/linux/bootmem.h
> > +++ b/include/linux/bootmem.h
> > @@ -96,20 +96,26 @@ extern void *__alloc_bootmem_low_node(pg_data_t *pgdat,
> >  				      unsigned long align,
> >  				      unsigned long goal);
> >  
> > +#ifdef MAX_DMA32_PFN
> > +#define BOOTMEM_DEFAULT_GOAL	(__pa(MAX_DMA32_PFN << PAGE_SHIFT))
> > +#else
> > +#define BOOTMEM_DEFAULT_GOAL	MAX_DMA_ADDRESS
> 
> I just noticed this should write:
> #define BOOTMEM_DEFAULT_GOAL   __pa(MAX_DMA_ADDRESS)

Pardon my sloppiness, it's all backwards.  The other case should
be without the __pa(), of course.

I'll send a fixed and tested version later.

Thanks,
	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ