linux-kernel - Re: [patch 2/2] sata_via: Delay on vt6420 when starting ATAPI DMA write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B5678E2.2050709@gmail.com>
Date:	Wed, 20 Jan 2010 12:30:42 +0900
From:	Tejun Heo <htejun@...il.com>
To:	Bart Hartgers <bart.hartgers@...il.com>
CC:	linux-kernel@...r.kernel.org, Jeff Garzik <jgarzik@...ox.com>,
	linux-ide@...r.kernel.org, juergen.metzdorf@...elev-dsl.de,
	markpschool@...mail.com, sporadic.crash@...il.com, apopov@...ma.bg,
	david@...mber.co.za, jay4mail@...il.com
Subject: Re: [patch 2/2] sata_via: Delay on vt6420 when starting ATAPI DMA
 write

Hello,

On 01/17/2010 08:56 AM, Bart Hartgers wrote:
> When writing a disc on certain lite-on dvd-writers (also rebadged as
> optiarc/LG/...) connected to a vt6420, the ATAPI CDB ends up in the
> datastream and on the disc, causing silent corruption.  Delaying
> between sending the CDB and starting DMA seems to prevent this.
> 
> I do not know if there are burners that do not suffer from this, but
> the patch should be safe for those as well.
> 
> There are many reports of this issue, but AFAICT no solution was 
> found before. For example:
> http://lkml.indiana.edu/hypermail/linux/kernel/0802.3/0561.html
> 
> Signed-off-by: Bart Hartgers <bart.hartgers@...il.com>

Ah... you found solution for this?  That's great.  This is one of the
three problems that have been lingering for years - the other two
being pata_ali ATAPI DMA problem and sata_sil data corruption problem.
I'll be ecstatic if this fix works.  Just one thing, I don't think
we'll need a warning message there.  It's useful during development
but it doesn't really provide any useful information afterwards.

Digging up the mailing list and cc'ing people who have reported this
problem.  If you still have the affected systems, can you guys please
test the patch in the following message and see whether it fixes the
problem?

  http://article.gmane.org/gmane.linux.kernel/939112/raw

Thanks a lot.  :-)

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/