linux-kernel - Re: linux-next: driver-core tree build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100120172543.e884a8af.sfr@canb.auug.org.au>
Date:	Wed, 20 Jan 2010 17:25:43 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Greg KH <greg@...ah.com>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: linux-next: driver-core tree build warning

Hi Greg,

On Wed, 20 Jan 2010 10:45:25 +1100 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> On Tue, 19 Jan 2010 13:04:17 -0800 Greg KH <greg@...ah.com> wrote:
> >
> > On Tue, Jan 19, 2010 at 05:27:41PM +1100, Stephen Rothwell wrote:
> > > 
> > > Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
> > > 
> > > drivers/base/cpu.c:264: warning: initialization from incompatible pointer type
> > > drivers/base/cpu.c:265: warning: initialization from incompatible pointer type
> > > 
> > > Introduced by commit 380567d3dc35a62f5cc0ec640a45dfc238238417 ("sysdev:
> > > Convert node driver")?
> > 
> > No, I don't think that patch causes the warning, I can't duplicate it
> > here.
> > 
> > I don't know what patch causes that problem, as I can't duplicate it in
> > my tree at all.  Maybe some 'const' patch snuck in from some other tree?
> > 
> > strange,
> 
> OK, if it is still there today, I will look deeper.

I still get those warnings.  The two referenced lines are added by the commit above.  The relevant parts of the file (in the version I have) are:

(lines 98 and 99)
static CLASS_ATTR(probe, S_IWUSR, NULL, cpu_probe_store);
static CLASS_ATTR(release, S_IWUSR, NULL, cpu_release_store);

...

(lines 262-266)
static struct sysdev_class_attribute *cpu_sysdev_class_attrs[] = {
#ifdef CONFIG_ARCH_CPU_PROBE_RELEASE
        &class_attr_probe.attr,
        &class_attr_release.attr,
#endif


class_attr_probe.attr is a "struct attribute" not a "struct
sysdev_class_attribute".

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped