linux-kernel - Re: [PATCH 4/9] net/sctp: Eliminate useless code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1001211121500.13529@ask.diku.dk>
Date:	Thu, 21 Jan 2010 11:22:38 +0100 (CET)
From:	Julia Lawall <julia@...u.dk>
To:	David Miller <davem@...emloft.net>
Cc:	vladislav.yasevich@...com, sri@...ibm.com,
	linux-sctp@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 4/9] net/sctp: Eliminate useless code

On Wed, 20 Jan 2010, David Miller wrote:

> From: Vlad Yasevich <vladislav.yasevich@...com>
> Date: Wed, 20 Jan 2010 13:10:10 -0500
> 
> > 
> > 
> > Julia Lawall wrote:
> >> From: Julia Lawall <julia@...u.dk>
> >> 
> >> The variable newinet is initialized twice to the same (side effect-free)
> >> expression.  Drop one initialization.
> >> 
> >> A simplified version of the semantic match that finds this problem is:
> >> (http://coccinelle.lip6.fr/)
> >> 
> >> // <smpl>
> >> @forall@
> >> idexpression *x;
> >> identifier f!=ERR_PTR;
> >> @@
> >> 
> >> x = f(...)
> >> ... when != x
> >> (
> >> x = f(...,<+...x...+>,...)
> >> |
> >> * x = f(...)
> >> )
> >> // </smpl>
> >> 
> >> Signed-off-by: Julia Lawall <julia@...u.dk>
> > 
> > Acked-by: Vlad Yasevich <vladislav.yasevich@...com>
> 
> Julia,  just like patch #3 this one had the missing final
> line of the patch corrupting it, so you'll need to resubmit.

I have generated and sent it again, but this time I don't see the problem.  
If there is still a problem, perhaps you could send me back the patch you 
received?

thanks,
julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/