linux-kernel - Re: perf record -g hangs the system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100121111850.GD5017@nowhere>
Date:	Thu, 21 Jan 2010 12:18:52 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Luca Barbieri <luca@...a-barbieri.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: perf record -g hangs the system

On Thu, Jan 21, 2010 at 12:10:12PM +0100, Luca Barbieri wrote:
> I'm experiencing a system lockup running the following command:
> perf record -g true
> 
> The system hangs and does not respond to any sysrq.
> No messages are printed to netconsole.
> 
> This is with 2.6.33-rc4 on an x86-32 Core 2 dual core machine.
> 
> Any tips on how to debug/fix this?



It should be fixed in latest linus's git tree with the
following patch:


commit c2c5d45d46c8c0fd34291dec958670ad4816796f
Author: Frederic Weisbecker <fweisbec@...il.com>
Date:   Thu Dec 31 03:52:25 2009 +0100

    perf: Stop stack frame walking off kernel addresses boundaries
    
    While processing kernel perf callchains, an bad entry can be
    considered as a valid stack pointer but not as a kernel address.
    
    In this case, we hang in an endless loop. This can happen in an
    x86-32 kernel after processing the last entry in a kernel
    stacktrace.
    
    Just stop the stack frame walking after we encounter an invalid
    kernel address.
    
    This fixes a hard lockup in x86-32.
    
    Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
    Cc: Peter Zijlstra <peterz@...radead.org>
    Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
    Cc: Paul Mackerras <paulus@...ba.org>
    LKML-Reference: <1262227945-27014-1-git-send-regression-fweisbec@...il.com>
    Signed-off-by: Ingo Molnar <mingo@...e.hu>

diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index c56bc28..6d81755 100644
--- a/arch/x86/kernel/dumpstack.c
+++ b/arch/x86/kernel/dumpstack.c
@@ -123,13 +123,15 @@ print_context_stack_bp(struct thread_info *tinfo,
 	while (valid_stack_ptr(tinfo, ret_addr, sizeof(*ret_addr), end)) {
 		unsigned long addr = *ret_addr;
 
-		if (__kernel_text_address(addr)) {
-			ops->address(data, addr, 1);
-			frame = frame->next_frame;
-			ret_addr = &frame->return_address;
-			print_ftrace_graph_addr(addr, data, ops, tinfo, graph);
-		}
+		if (!__kernel_text_address(addr))
+			break;
+
+		ops->address(data, addr, 1);
+		frame = frame->next_frame;
+		ret_addr = &frame->return_address;
+		print_ftrace_graph_addr(addr, data, ops, tinfo, graph);
 	}
+
 	return (unsigned long)frame;
 }
 EXPORT_SYMBOL_GPL(print_context_stack_bp);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/