linux-kernel - Re: [PATCH] Obsolete config in kernel source (USB_HCD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100121135847.GA25890@stud.informatik.uni-erlangen.de>
Date:	Thu, 21 Jan 2010 14:58:47 +0100
From:	Christoph Egger <siccegge@...d.informatik.uni-erlangen.de>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Sergei Shtylyov <sshtylyov@...mvista.com>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	ok@...ecdesign.ee, sarah.a.sharp@...ux.intel.com,
	Reinhard.Tartler@...ormatik.uni-erlangen.de
Subject: Re: [PATCH] Obsolete config in kernel source (USB_HCD_DMA)

On Wed, Jan 20, 2010 at 08:38:06AM -0800, Randy Dunlap wrote:
> On Wed, 20 Jan 2010 17:20:18 +0300 Sergei Shtylyov wrote:
> >
> >    The patch's subject should be a terse description of change, not the 
> > substitute for the lengthy description as in your case.
> 
> Also please insert patches inline in the email body instead of using
> attachments.  mutt can surely do this -- people do it all the time
> (though I don't use mutt, so please don't ask me how).

---
>From 2e5a8a322a6cd74ecb77eda8f0a09a0a01c6dbc6 Mon Sep 17 00:00:00 2001
From: Christoph Egger <siccegge@...d.informatik.uni-erlangen.de>
Date: Wed, 20 Jan 2010 13:32:36 +0100
Subject: [PATCH] remove code block depending on unreferenced config item USB_HCD_DMA

The configuration Option USB_HCD_DMA is not reachable in KConfig so
this piece of Code is effectively dead and useless. Remove it to avoid
confusion.

Signed-off-by: Christoph Egger <siccegge@...d.informatik.uni-erlangen.de>
---
 drivers/usb/host/isp1362-hcd.c |   13 -------------
 1 files changed, 0 insertions(+), 13 deletions(-)

diff --git a/drivers/usb/host/isp1362-hcd.c b/drivers/usb/host/isp1362-hcd.c
index 73352f3..341db2c 100644
--- a/drivers/usb/host/isp1362-hcd.c
+++ b/drivers/usb/host/isp1362-hcd.c
@@ -2716,24 +2716,11 @@ static int __init isp1362_probe(struct platform_device *pdev)
 		goto err1;
 	}
 
-#ifdef CONFIG_USB_HCD_DMA
-	if (pdev->dev.dma_mask) {
-		struct resource *dma_res = platform_get_resource(pdev, IORESOURCE_MEM, 2);
-
-		if (!dma_res) {
-			retval = -ENODEV;
-			goto err1;
-		}
-		isp1362_hcd->data_dma = dma_res->start;
-		isp1362_hcd->max_dma_size = resource_len(dma_res);
-	}
-#else
 	if (pdev->dev.dma_mask) {
 		DBG(1, "won't do DMA");
 		retval = -ENODEV;
 		goto err1;
 	}
-#endif
 
 	if (!request_mem_region(addr->start, resource_len(addr), hcd_name)) {
 		retval = -EBUSY;
-- 
1.6.3.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/