linux-kernel - Re: [PATCH 05/36] x86/pci: enable pci root res read out for 32bit too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1001210750140.13231@localhost.localdomain>
Date:	Thu, 21 Jan 2010 07:54:39 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Yinghai Lu <yinghai@...nel.org>
cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Christoph Lameter <cl@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH 05/36] x86/pci: enable pci root res read out for 32bit
 too



On Wed, 20 Jan 2010, Yinghai Lu wrote:
>
>  			printk(KERN_DEBUG "bus: %02x index %x %s: [%llx, %llx]\n",
>  			       busnum, j,
>  			       (res->flags & IORESOURCE_IO)?"io port":"mmio",
> -			       res->start, res->end);
> +			       (u64)res->start, (u64)res->end);

When fixing these kinds of things, please just make it use '%pR' instead.

A simple

	printk(KERN_DEBUG "bus: %02x index %x %pR\n", busnum, j, res);

should do the right thing, printing the resource with nice human-readable 
flags. Including things like 64-bit/prefetching information for memory 
resources etc that the current manual resource printout doesn't do.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/