linux-kernel - Re: [patch] x86: set hotpluggable nodes in nodes_possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B57C330.7020505@linux.intel.com>
Date:	Thu, 21 Jan 2010 11:00:00 +0800
From:	Haicheng Li <haicheng.li@...ux.intel.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	David Rientjes <rientjes@...gle.com>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org
Subject: Re: [patch] x86: set hotpluggable nodes in nodes_possible_map

Yinghai Lu wrote:
> 
>         if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) {
>                 update_nodes_add(node, start, end);
>                 /* restore nodes[node] */
>                 *nd = oldnode;
>                 if ((nd->start | nd->end) == 0)
>                         node_clear(node, nodes_parsed);
>         }
> 
> removing clearing with nodes_parsed is not working?
> 
> YH

Yinghai,

Theoretically removing clearing with nodes_parsed can work fine except that it requires more 
consideration, since some functions already based on nodes_parsed, like acpi_get_nodes(), is 
supposing nodes_parsed just represents for nodes with memory on.

See my another email to David, I think we'd better keep hotpluggable node info separately since it 
is straightforward as well as would be useful for future hotplug related usage. How do you think 
about it? thanks.

-haicheng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/