linux-kernel - Re: [PATCH] lib/dma-debug.c: mark file-local struct symbol static.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100122170137.GK8665@amd.com>
Date:	Fri, 22 Jan 2010 18:01:37 +0100
From:	Joerg Roedel <joerg.roedel@....com>
To:	Thiago Farina <tfransosi@...il.com>
CC:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Subject: Re: [PATCH] lib/dma-debug.c: mark file-local struct symbol static.

On Mon, Jan 18, 2010 at 06:57:33PM -0500, Thiago Farina wrote:
> warning: symbol 'filter_fops' was not declared. Should it be static?
> 
> Signed-off-by: Thiago Farina <tfransosi@...il.com>
> ---
>  lib/dma-debug.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/dma-debug.c b/lib/dma-debug.c
> index 7d2f0b3..ba8b670 100644
> --- a/lib/dma-debug.c
> +++ b/lib/dma-debug.c
> @@ -587,7 +587,7 @@ out_unlock:
>  	return count;
>  }
>  
> -const struct file_operations filter_fops = {
> +static const struct file_operations filter_fops = {
>  	.read  = filter_read,
>  	.write = filter_write,
>  };

Applied to dma-debug/fixes. Thanks.

	Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/