linux-kernel - [tip:sched/core] sched: Queue a deboosted task to the head of the RT prio queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-60db48cacb9b253d5607a5ff206112a59cd09e34@git.kernel.org>
Date:	Fri, 22 Jan 2010 17:13:04 GMT
From:	tip-bot for Thomas Gleixner <tglx@...utronix.de>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	peterz@...radead.org, cbe@...dl.org, mathias.weber.mw1@...he.com,
	tglx@...utronix.de
Subject: [tip:sched/core] sched: Queue a deboosted task to the head of the RT prio queue

Commit-ID:  60db48cacb9b253d5607a5ff206112a59cd09e34
Gitweb:     http://git.kernel.org/tip/60db48cacb9b253d5607a5ff206112a59cd09e34
Author:     Thomas Gleixner <tglx@...utronix.de>
AuthorDate: Wed, 20 Jan 2010 20:59:06 +0000
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Fri, 22 Jan 2010 18:09:59 +0100

sched: Queue a deboosted task to the head of the RT prio queue

rtmutex_set_prio() is used to implement priority inheritance for
futexes. When a task is deboosted it gets enqueued at the tail of its
RT priority list. This is violating the POSIX scheduling semantics:

rt priority list X contains two runnable tasks A and B

task A	 runs with priority X and holds mutex M
task C	 preempts A and is blocked on mutex M 
     	 -> task A is boosted to priority of task C (Y)
task A	 unlocks the mutex M and deboosts itself
     	 -> A is dequeued from rt priority list Y
	 -> A is enqueued to the tail of rt priority list X
task C	 schedules away
task B	 runs

This is wrong as task A did not schedule away and therefor violates
the POSIX scheduling semantics.

Enqueue the task to the head of the priority list instead. 

Reported-by: Mathias Weber <mathias.weber.mw1@...he.com>
Reported-by: Carsten Emde <cbe@...dl.org>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Acked-by: Peter Zijlstra <peterz@...radead.org>
Tested-by: Carsten Emde <cbe@...dl.org>
Tested-by: Mathias Weber <mathias.weber.mw1@...he.com>
LKML-Reference: <20100120171629.809074113@...utronix.de>
---
 kernel/sched.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index f47560f..a56ead4 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -4237,7 +4237,7 @@ void rt_mutex_setprio(struct task_struct *p, int prio)
 	if (running)
 		p->sched_class->set_curr_task(rq);
 	if (on_rq) {
-		enqueue_task(rq, p, 0, false);
+		enqueue_task(rq, p, 0, oldprio < prio);
 
 		check_class_changed(rq, p, prev_class, oldprio, running);
 	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/