linux-kernel - Re: [PATCH 3/4] MTD: blkdevs: make hotplug work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1264197077.2824.8.camel@maxim-laptop>
Date:	Fri, 22 Jan 2010 23:51:17 +0200
From:	Maxim Levitsky <maximlevitsky@...il.com>
To:	dedekind1@...il.com
Cc:	David Woodhouse <dwmw2@...radead.org>,
	linux-mtd <linux-mtd@...ts.infradead.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Alex Dubov <oakad@...oo.com>, joern <joern@...fs.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 3/4] MTD: blkdevs: make hotplug work

On Fri, 2010-01-22 at 17:59 +0200, Artem Bityutskiy wrote: 
> On Fri, 2010-01-22 at 17:35 +0200, Maxim Levitsky wrote:
> > >From 368127067f4d39ba89096e4a5cb3be2dee361bad Mon Sep 17 00:00:00 2001
> > From: Maxim Levitsky <maximlevitsky@...il.com>
> > Date: Fri, 22 Jan 2010 15:00:55 +0200
> > Subject: [PATCH 3/4] MTD: blkdevs: make hotplug work
> > 
> > This changes the blkdev common module for translation layers
> > to survive when underlying mtd device disappears.
> > 
> > To do so the following conceptual changes were made:
> > 
> > * disk queue and thread are now one per mtd device
> >  This was it is easy to flush and destroy the queue
> > 
> > * the struct mtd_blktrans_dev will now be freed automaticly when last user
> >  of the device quits.
> >  All existing translation layers are adjusted
> > 
> > * ->open and release function of the translation layer will never be called
> >  twise or more in the row.
> >  This makes code simplier.
> >  Also the ->release will be called just before mtd device disappears
> >  This and above is the only visable changes on the outside.
> > 
> > Tested with mtdblock, ssfdc and my own sm_ftl on top of physicly hotplugable
> > nand card.
> > 
> > Signed-off-by: Maxim Levitsky <maximlevitsky@...il.com>
> 
> I'll try to find some time to review this later - I'm really busy
> lately. But please, split this huge patch on smaller pieces - this will
> help the reviewers a lot.
> 
Sure, but I afraid this won't be easy. To split the patch I will need
effectively to redo all the work from the beginning.
Isn't it possible just to review the mtd_blkdevs.c and blktrans.h as
if it was new driver?

This patch does touch all ftl drivers, but only removes the final free
of structure that holds or embeds the 'struct mtd_blktrans_dev'

Change in drivers/mtd/mtdcore.c is my mistake, this slipped from
previous patch, sorry.

Do you think its real to merge my work into 2.6.34 ?
What else should I do besides splitting this patch?

Best regards,
Maxim Levitsky






--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/