linux-kernel - RE: [PATCH] bfa: comparison with wrong msgtag in bfa_pport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <04391A4E90BB2149B010D22452FA16875F0348DF@HQ-EXCH-6.corp.brocade.com>
Date:	Thu, 21 Jan 2010 17:59:35 -0800
From:	Jing Huang <huangj@...cade.COM>
To:	Roel Kluin <roel.kluin@...il.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
CC:	Adapter Linux Open SRC Team 
	<adapter_linux_open_src_team@...cade.COM>
Subject: RE: [PATCH] bfa: comparison with wrong msgtag in bfa_pport_isr()

> Was this maybe intended? otherwise in case BFI_PPORT_I2H_ENABLE_RSP:
> the same code is executed. Please review.

Making this change alone will break compilation since bfa_pport_disable_rsp_s is not defined. To fix this, we should also replace it with bfa_pport_generic_rsp_s in bfi_pport_i2h_msg_u.

But please keep this as it is for now since I am working on resubmitting 2.1.2.1 patch, and there are a lot of changes in this area.

Thanks

Jing

> 
> diff --git a/drivers/scsi/bfa/bfa_fcport.c b/drivers/scsi/bfa/bfa_fcport.c
> index aef648b..f00d07b 100644
> --- a/drivers/scsi/bfa/bfa_fcport.c
> +++ b/drivers/scsi/bfa/bfa_fcport.c
> @@ -918,7 +918,7 @@ bfa_pport_isr(struct bfa_s *bfa, struct bfi_msg_s
> *msg)
>  		break;
> 
>  	case BFI_PPORT_I2H_DISABLE_RSP:
> -		if (pport->msgtag == i2hmsg.enable_rsp->msgtag)
> +		if (pport->msgtag == i2hmsg.disable_rsp->msgtag)
>  			bfa_sm_send_event(pport, BFA_PPORT_SM_FWRSP);
>  		break;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/