[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <28939.1264126458@localhost>
Date: Thu, 21 Jan 2010 21:14:18 -0500
From: Valdis.Kletnieks@...edu
To: Andi Kleen <andi@...stfloor.org>
Cc: linux-kernel@...r.kernel.org, x86@...nel.org,
robert.richter@....com, oprofile-list@...ts.sf.net
Subject: Re: [PATCH] Add Xeon 7500 series support to oprofile
On Thu, 21 Jan 2010 23:26:27 +0100, Andi Kleen said:
> Add Xeon 7500 series support to oprofile
>
> Straight forward: it's the same as Core i7, so just detect
> the model number. No user space changes needed.
>
> Very simple patch, so it could be still merged for .33?
>
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
>
> ---
> arch/x86/oprofile/nmi_int.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux/arch/x86/oprofile/nmi_int.c
> ===================================================================
> --- linux.orig/arch/x86/oprofile/nmi_int.c
> +++ linux/arch/x86/oprofile/nmi_int.c
> @@ -598,6 +598,7 @@ static int __init ppro_init(char **cpu_t
> case 15: case 23:
> *cpu_type = "i386/core_2";
> break;
> + case 0x2e:
> case 26:
> spec = &op_arch_perfmon_spec;
> *cpu_type = "i386/core_i7";
I'll bite - why a hex constant rather than the decimal values nearby?
Also, should we do something about *cpu_type so it isn't confusing on a 7500
reporting itself as a i7?
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists