linux-kernel - Re: [PATCH 31/31] CAPI: Officially claim char major 191

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1264256753.3469.55.camel@violet>
Date:	Sat, 23 Jan 2010 15:25:53 +0100
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Jan Kiszka <jan.kiszka@....de>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	David Miller <davem@...emloft.net>,
	Karsten Keil <isdn@...ux-pingi.de>,
	linux-kernel@...r.kernel.org, i4ldeveloper@...tserv.isdn4linux.de,
	isdn4linux@...tserv.isdn4linux.de, netdev@...r.kernel.org,
	Alan Cox <alan@...ux.intel.com>
Subject: Re: [PATCH 31/31] CAPI: Officially claim char major 191

Hi Jan,

> >>> I found no trace of this mysterious "pcl181" device, neither in-tree nor
> >>> out there in the wild. At the same time, the in-tree CAPI middleware is
> >>> using major 191 for many years now and obviously without any conflict.
> >>> Let's officially claim this major number.
> >> This is not the way it should have been done but whoever needs spanking
> >> got away with it years ago. Given that this seems the best way forward.
> >>
> >> With LANANA hat on
> > 
> > actually in the days of udev, the capifs is not really needed anymore.
> > The right choice would be to remove it. I haven't been enabling it since
> > years.
> 
> First of all, the capifs story is orthogonal to the major claim.

my point here is merely that when using udev, you need to fixed assigned
major number. Dynamic major numbers will just work fine.

> But basically you are right, capifs is likely not needed anymore. The
> only user visible change - and that was holding me back to suggest its
> removal - is the time when the NCCI minor ttys show up under /dev/capi/
> (or wherever you direct them to). If I didn't miss something about udev,
> it will make all possible minors pop up once the major is registered.
> However, I'm not sure if there is some userland actually relying on this.

That is just an issue with the current code. There is no requirement to
create all minors are at the same. You can create/remove minors on
demand as you please. And udev will take care of the device nodes for
you.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/