[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1264278937-19675-6-git-send-email-u.kleine-koenig@pengutronix.de>
Date: Sat, 23 Jan 2010 21:35:14 +0100
From: Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
To: Greg KH <gregkh@...e.de>
Cc: linux-kernel@...r.kernel.org, Eric Miao <eric.miao@...vell.com>,
Russell King <rmk+kernel@....linux.org.uk>,
Paul Sokolovsky <pmiscml@...il.com>,
Richard Purdie <rpurdie@...ys.net>,
Liam Girdwood <liam.girdwood@...fsonmicro.com>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: [PATCH 06/29] move corgi-ssp's probe function to .devinit.text
A pointer to corgi_ssp_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded. Otherwise (when having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.
An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Eric Miao <eric.miao@...vell.com>
Cc: Russell King <rmk+kernel@....linux.org.uk>
Cc: Paul Sokolovsky <pmiscml@...il.com>
Cc: Richard Purdie <rpurdie@...ys.net>
Cc: Liam Girdwood <liam.girdwood@...fsonmicro.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>
---
arch/arm/mach-pxa/corgi_ssp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-pxa/corgi_ssp.c b/arch/arm/mach-pxa/corgi_ssp.c
index a5ee707..1d9bc11 100644
--- a/arch/arm/mach-pxa/corgi_ssp.c
+++ b/arch/arm/mach-pxa/corgi_ssp.c
@@ -204,7 +204,7 @@ void __init corgi_ssp_set_machinfo(struct corgissp_machinfo *machinfo)
ssp_machinfo = machinfo;
}
-static int __init corgi_ssp_probe(struct platform_device *dev)
+static int __devinit corgi_ssp_probe(struct platform_device *dev)
{
int ret;
--
1.6.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists