[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1264278937-19675-20-git-send-email-u.kleine-koenig@pengutronix.de>
Date: Sat, 23 Jan 2010 21:35:28 +0100
From: Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
To: Greg KH <gregkh@...e.de>
Cc: linux-kernel@...r.kernel.org,
Russell King <rmk+kernel@....linux.org.uk>,
Matthias Kaehlcke <matthias@...hlcke.net>,
Andrew Morton <akpm@...ux-foundation.org>,
Antonino Daplas <adaplas@...il.com>,
Pavel Machek <pavel@...e.cz>, Christoph Hellwig <hch@....de>
Subject: [PATCH 20/29] move sa11x0-fb's probe function to .devinit.text
A pointer to sa1100fb_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded. Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.
An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Russell King <rmk+kernel@....linux.org.uk>
Cc: Matthias Kaehlcke <matthias@...hlcke.net>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Antonino Daplas <adaplas@...il.com>
Cc: Pavel Machek <pavel@...e.cz>
Cc: Christoph Hellwig <hch@....de>
---
drivers/video/sa1100fb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/sa1100fb.c b/drivers/video/sa1100fb.c
index cdaa873..e8b76d6 100644
--- a/drivers/video/sa1100fb.c
+++ b/drivers/video/sa1100fb.c
@@ -1435,7 +1435,7 @@ static struct sa1100fb_info * __init sa1100fb_init_fbinfo(struct device *dev)
return fbi;
}
-static int __init sa1100fb_probe(struct platform_device *pdev)
+static int __devinit sa1100fb_probe(struct platform_device *pdev)
{
struct sa1100fb_info *fbi;
int ret, irq;
--
1.6.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists